Add Allow space option #6

nmbakfm · 2017-12-06T08:28:50Z

add allow_space option to katakana and hiragana

like this:

validates hiragana: { allow_space: true }
validates katakana: { allow_space: true }

houndci-bot · 2017-12-06T08:29:02Z

spec/validations/katakana_validator_spec.rb

+    [
+      ' ',
+      ' カタ カナー ',
+      'カタ　カナー',


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-12-06T08:29:02Z

spec/validations/katakana_validator_spec.rb

+  context 'valid katakana(allow_space)' do
+    [
+      ' ',
+      ' カタ カナー ',


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-12-06T08:29:03Z

spec/validations/katakana_validator_spec.rb

+
+  context 'valid katakana(allow_space)' do
+    [
+      ' ',


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-12-06T08:29:03Z

spec/validations/katakana_validator_spec.rb

    ].each do |katakana|
      it "#{katakana} should be valid" do
        expect(KatakanaModel.new(katakana: katakana)).not_to be_valid
      end
    end
  end
+
+  context 'valid katakana(allow_space)' do


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-12-06T08:29:03Z

spec/validations/katakana_validator_spec.rb

    ].each do |katakana|
      it "#{katakana} should be valid" do
        expect(KatakanaModel.new(katakana: katakana)).not_to be_valid
      end
    end
  end
+


Trailing whitespace detected.

houndci-bot · 2017-12-06T08:29:03Z

spec/validations/hiragana_validator_spec.rb

    ].each do |hiragana|
      it "#{hiragana} should be valid" do
        expect(HiraganaModel.new(hiragana: hiragana)).not_to be_valid
      end
    end
  end
+
+  context 'valid hiragana' do


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-12-06T08:29:03Z

spec/validations/hiragana_validator_spec.rb

    ].each do |hiragana|
      it "#{hiragana} should be valid" do
        expect(HiraganaModel.new(hiragana: hiragana)).not_to be_valid
      end
    end
  end
+


Trailing whitespace detected.

houndci-bot · 2017-12-06T08:29:04Z

spec/validations/hiragana_validator_spec.rb

@@ -24,10 +28,23 @@ class HiraganaModel < TestModel
      'カタカナ',
      '漢字',
      'ひらがなとカタカナ',
+      'ひら がなー',


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-12-06T08:29:04Z

lib/roshi/version.rb

@@ -1,3 +1,3 @@
 module Roshi
-  VERSION = '0.8.0'
+  VERSION = '0.8.1'


Freeze mutable objects assigned to constants.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-12-06T08:29:04Z

lib/roshi/active_model/validations/katakana_validator.rb

@@ -2,7 +2,8 @@ module ActiveModel
  module Validations
    class KatakanaValidator < EachValidator
      def validate_each(record, attribute, value)
-        unless value =~ /\A[\p{katakana}ー－]*\z/i
+        space = options[:allow_space] ? '[:blank:]' : ""


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-12-06T08:32:50Z

spec/validations/katakana_validator_spec.rb

+    [
+      ' ',
+      ' カタ カナー ',
+      'カタ　カナー'


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-12-06T08:32:51Z

spec/validations/katakana_validator_spec.rb

 describe 'KatakanaValidator' do
  context 'valid katakana' do
    [
      '',
      'カタカナ',
-      'カタカナー',
+      'カタカナー'


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-12-06T08:32:51Z

spec/validations/hiragana_validator_spec.rb

+    [
+      ' ',
+      ' ひら がな ',
+      'ひら　がなー'


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-12-06T08:32:51Z

spec/validations/hiragana_validator_spec.rb

@@ -24,10 +28,23 @@ class HiraganaModel < TestModel
      'カタカナ',
      '漢字',
      'ひらがなとカタカナ',
+      'ひら がなー'


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-12-06T08:32:51Z

spec/validations/hiragana_validator_spec.rb

 describe 'HiraganaValidator' do
  context 'valid hiragana' do
    [
      '',
      'ひらがな',
-      'ひらがなー',
+      'ひらがなー'


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

nmbakfm · 2017-12-06T08:36:15Z

@kawahiro311 @Kta-M review this.

houndci-bot · 2018-07-12T08:41:55Z

lib/roshi/active_model/validations/katakana_validator.rb

@@ -2,7 +2,8 @@ module ActiveModel
  module Validations
    class KatakanaValidator < EachValidator
      def validate_each(record, attribute, value)
-        unless value =~ /\A[\p{katakana}ー－]*\z/i
+        space = options[:allow_space] ? '[:blank:]' : ''


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-12T08:41:55Z

spec/validations/katakana_validator_spec.rb

+    [
+      ' ',
+      ' カタ カナー ',
+      'カタ　カナー'


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-12T08:41:55Z

spec/validations/katakana_validator_spec.rb

+  context 'valid katakana(allow_space)' do
+    [
+      ' ',
+      ' カタ カナー ',


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-12T08:41:55Z

spec/validations/katakana_validator_spec.rb

+
+  context 'valid katakana(allow_space)' do
+    [
+      ' ',


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-12T08:41:55Z

spec/validations/katakana_validator_spec.rb

    ].each do |katakana|
      it "#{katakana} should be valid" do
        expect(KatakanaModel.new(katakana: katakana)).not_to be_valid
      end
    end
  end
+
+  context 'valid katakana(allow_space)' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-12T08:41:56Z

spec/validations/hiragana_validator_spec.rb

    ].each do |hiragana|
      it "#{hiragana} should be valid" do
        expect(HiraganaModel.new(hiragana: hiragana)).not_to be_valid
      end
    end
  end
+
+  context 'valid hiragana' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-12T08:41:56Z

spec/validations/hiragana_validator_spec.rb

    ].each do |hiragana|
      it "#{hiragana} should be valid" do
        expect(HiraganaModel.new(hiragana: hiragana)).not_to be_valid
      end
    end
  end
+


Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2018-07-12T08:41:57Z

spec/validations/hiragana_validator_spec.rb

@@ -24,10 +28,23 @@ class HiraganaModel < TestModel
      'カタカナ',
      '漢字',
      'ひらがなとカタカナ',
+      'ひら がなー'


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-12T08:41:57Z

spec/validations/hiragana_validator_spec.rb

 describe 'HiraganaValidator' do
  context 'valid hiragana' do
    [
      '',
      'ひらがな',
-      'ひらがなー',
+      'ひらがなー'


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-12T08:41:57Z

lib/roshi/active_model/validations/hiragana_validator.rb

@@ -2,7 +2,8 @@ module ActiveModel
  module Validations
    class HiraganaValidator < EachValidator
      def validate_each(record, attribute, value)
-        unless value =~ /\A[\p{hiragana}ー－]*\z/i
+        space = options[:allow_space] ? '[:blank:]' : ''


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Kta-M

ok farm!

nmbakfm added 3 commits June 22, 2017 18:08

Release v0.8.1

a8da188

Add allow_space option

aedb035

change README

85ae53a

nmbakfm added the enhancement label Dec 6, 2017

nmbakfm self-assigned this Dec 6, 2017

nmbakfm requested review from kawahiro311 and Kta-M December 6, 2017 08:28

houndci-bot reviewed Dec 6, 2017

View reviewed changes

double quote => single quote, remove last comma of array

eb85f83

houndci-bot reviewed Dec 6, 2017

View reviewed changes

nmbakfm added 2 commits December 6, 2017 17:37

fix inner space of Hash

29d7923

Merge branch 'master' into allow_space_option

76479ab

houndci-bot reviewed Jul 12, 2018

View reviewed changes

Kta-M approved these changes Mar 20, 2019

View reviewed changes

nmbakfm merged commit 22e7574 into master Mar 22, 2019

nmbakfm deleted the allow_space_option branch March 22, 2019 01:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Allow space option #6

Add Allow space option #6

nmbakfm commented Dec 6, 2017 •

edited

Loading

houndci-bot Dec 6, 2017

houndci-bot Dec 6, 2017

houndci-bot Dec 6, 2017

houndci-bot Dec 6, 2017

houndci-bot Dec 6, 2017

houndci-bot Dec 6, 2017

houndci-bot Dec 6, 2017

houndci-bot Dec 6, 2017

houndci-bot Dec 6, 2017

houndci-bot Dec 6, 2017

houndci-bot Dec 6, 2017

houndci-bot Dec 6, 2017

houndci-bot Dec 6, 2017

houndci-bot Dec 6, 2017

houndci-bot Dec 6, 2017

nmbakfm commented Dec 6, 2017

houndci-bot Jul 12, 2018

houndci-bot Jul 12, 2018

houndci-bot Jul 12, 2018

houndci-bot Jul 12, 2018

houndci-bot Jul 12, 2018

houndci-bot Jul 12, 2018

houndci-bot Jul 12, 2018

houndci-bot Jul 12, 2018

houndci-bot Jul 12, 2018

houndci-bot Jul 12, 2018

Kta-M left a comment

Add Allow space option #6

Add Allow space option #6

Conversation

nmbakfm commented Dec 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nmbakfm commented Dec 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kta-M left a comment

Choose a reason for hiding this comment

nmbakfm commented Dec 6, 2017 •

edited

Loading