-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #95 +/- ##
===========================================
+ Coverage 87.74% 88.34% +0.60%
===========================================
Files 6 6
Lines 310 326 +16
===========================================
+ Hits 272 288 +16
Misses 38 38
Continue to review full report at Codecov.
|
…y/openmc-dagmc-wrapper into wrapping_dagmc_bounding_box
That's really convenient @shimwell . Can the MeshTally tests be modified accordingly then? |
I can do that just to simplify things, but I don't think that wouldn't test anything new. |
I think it would cause, as far as I know, the examples aren't tested in GA or CircleCI. Which means that the integration of this new feature with the Mesh tallies isn't tested. |
I've updated the meshtally tests to make use of this and also updated the test in |
codiga comments are mainly regarding the url download for testing, this is a known problem |
These tests now fail. Must be due to a missing import |
Made some changes, now passing locally |
However this test exists in main
|
ah was I out of sync with develop, thanks for that merge |
I re-synced the branch with develop with the last commit. The problem came from the fact that #93 wasn't merged in develop but in main that was my mistake sorry about that |
I think the docker images building can also be improved. I think this can be fixed by adding docker layer caching to the build docker images script. But perhaps that should be solved that in another PR. |
…y/openmc-dagmc-wrapper into wrapping_dagmc_bounding_box
tests are passing, good to merge? |
Sounds good to me! |
This adds a
corners()
method to the Geometry class.corners
can be used to find the bounding box coordinates which is often needed for 2d or 3d mesh talliesThis makes use of the
dagmc-bounding-box
packageTests have been added to check the corners are accessible and correct.
Examples have been updated