Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding center point to center column cylinder #33

Merged
merged 6 commits into from
Jul 20, 2021

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Jul 19, 2021

Proposed changes

Allows the CenterColumnShieldCylinder to be shifted vertically using a new argument called center_height which defaults to 0

The following image can now be made with code like this

import paramak
inner_vessel = paramak.CenterColumnShieldCylinder(
    inner_radius=3,
    outer_radius=3.3,
    height=5,
    color=(0,0,1),
    center_height=0
)

inner_vessel2 = paramak.CenterColumnShieldCylinder(
    inner_radius=3,
    outer_radius=3.3,
    height=5,
    center_height=-6,
    color=(1,0,0)
)

inner_vessel3 = paramak.CenterColumnShieldCylinder(
    inner_radius=3,
    outer_radius=3.3,
    height=5,
    center_height=6,
    color=(0,1,0)
)

r = paramak.Reactor([inner_vessel, inner_vessel2, inner_vessel3])
r.show()

Screenshot 2021-07-19 150742

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #33 (473fde5) into develop (da53362) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #33   +/-   ##
========================================
  Coverage    97.48%   97.48%           
========================================
  Files           73       73           
  Lines         4805     4814    +9     
========================================
+ Hits          4684     4693    +9     
  Misses         121      121           
Impacted Files Coverage Δ
...ak/parametric_components/center_column_cylinder.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da53362...473fde5. Read the comment docs.

@shimwell
Copy link
Member Author

I don't have access to the method of making diagrams at the moment, so this PR really should have another parameter added to the diagram. I shall raise an issue so I don't forget

@shimwell shimwell merged commit 4a2f5fd into develop Jul 20, 2021
@shimwell shimwell deleted the adding_center_point_to_center_column_cylinder branch July 20, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant