-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated conda build #51
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #51 +/- ##
===========================================
- Coverage 94.61% 94.21% -0.40%
===========================================
Files 76 76
Lines 5183 5207 +24
===========================================
+ Hits 4904 4906 +2
- Misses 279 301 +22
Continue to review full report at Codecov.
|
The parts that are untested are the try except loops that try to import jupyter-cadquery and prevent conda tests failing |
…mak into automated_conda_build
Proposed changes
This PR is another step towards a conda package. This allows the conda package to be built, and pass the conda based tests.
cadquery-jupyter is now optional and the functions that make use of it return a warning message when it is not importable.
This allows the conda based tests to pass without having the package installed.
the circle ci and github action based tests run in an environment with jupyter-cadquery installed so these should be unaffected.
This PR fixes issue #49
Additionally the version number of the conda package is now taken from the setup.py and also the python version is now taken from the conda_build_config.yaml file. These make the build process more compatible with github actions based automation.
Types of changes
What types of changes does your code introduce to the Paramak?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.