Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed pymoab cubit h5m abilities #76

Merged
merged 5 commits into from
Aug 26, 2021

Conversation

shimwell
Copy link
Member

Proposed changes

As described in #75

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #76 (c865fba) into fixing_gh_action_to_permit_fails (49dfe8f) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                         Coverage Diff                          @@
##           fixing_gh_action_to_permit_fails      #76      +/-   ##
====================================================================
+ Coverage                             97.72%   97.90%   +0.18%     
====================================================================
  Files                                    75       75              
  Lines                                  5096     4869     -227     
====================================================================
- Hits                                   4980     4767     -213     
+ Misses                                  116      102      -14     
Impacted Files Coverage Δ
paramak/__init__.py 100.00% <ø> (ø)
paramak/parametric_reactors/ball_reactor.py 98.91% <ø> (-0.01%) ⬇️
...parametric_reactors/center_column_study_reactor.py 100.00% <ø> (ø)
...aramak/parametric_reactors/eu_demo_2015_reactor.py 100.00% <ø> (ø)
paramak/parametric_reactors/submersion_reactor.py 98.63% <ø> (-0.01%) ⬇️
paramak/utils.py 97.30% <ø> (+4.55%) ⬆️
paramak/reactor.py 91.95% <100.00%> (-0.95%) ⬇️
paramak/shape.py 96.43% <100.00%> (-1.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49dfe8f...c865fba. Read the comment docs.

@shimwell
Copy link
Member Author

Looks like everything is working

@shimwell shimwell merged commit 114496b into fixing_gh_action_to_permit_fails Aug 26, 2021
@shimwell shimwell deleted the modularisation_rewrite branch August 26, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant