-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additionnal tests for workplane #96
Conversation
Thanks Remi, should test.py be removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for finishing that. Feel free to merge when tests pass
Codecov Report
@@ Coverage Diff @@
## develop #96 +/- ##
===========================================
+ Coverage 98.20% 98.22% +0.02%
===========================================
Files 76 76
Lines 4890 4890
===========================================
+ Hits 4802 4803 +1
+ Misses 88 87 -1
Continue to review full report at Codecov.
|
Proposed changes
I think PR #84 was missing one or two tests (drop in coverage and patch coverage below 100%), so here they are
Types of changes
What types of changes does your code introduce to the Paramak?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.