Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additionnal tests for workplane #96

Merged
merged 10 commits into from
Sep 19, 2021
Merged

Conversation

RemDelaporteMathurin
Copy link
Member

@RemDelaporteMathurin RemDelaporteMathurin commented Sep 19, 2021

Proposed changes

I think PR #84 was missing one or two tests (drop in coverage and patch coverage below 100%), so here they are

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell
Copy link
Member

Thanks Remi, should test.py be removed

Copy link
Member

@shimwell shimwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for finishing that. Feel free to merge when tests pass

@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #96 (64f38a5) into develop (ba42876) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #96      +/-   ##
===========================================
+ Coverage    98.20%   98.22%   +0.02%     
===========================================
  Files           76       76              
  Lines         4890     4890              
===========================================
+ Hits          4802     4803       +1     
+ Misses          88       87       -1     
Impacted Files Coverage Δ
paramak/shape.py 97.16% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba42876...64f38a5. Read the comment docs.

@RemDelaporteMathurin RemDelaporteMathurin merged commit 660307a into develop Sep 19, 2021
@shimwell shimwell deleted the tests_workplane branch December 14, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants