Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed plotly with no error, fixed matplotlib legends #23

Merged

Conversation

py1sl
Copy link
Contributor

@py1sl py1sl commented Mar 2, 2022

minor fixes before tackling correct treatment of standard deviations

@shimwell
Copy link
Member

shimwell commented Mar 2, 2022

Thanks for this, I normally merge into develop then main (gitflow) but I can see I've totally scrambled the recent branching.

@shimwell
Copy link
Member

shimwell commented Mar 2, 2022

oh looks like my ci is broken as well

@shimwell
Copy link
Member

shimwell commented Mar 2, 2022

I can fix the CI and rerun this in a few mins

@shimwell
Copy link
Member

shimwell commented Mar 3, 2022

I've fixed the CI on the main branch, could you click the fetch upstream button on your fork please @py1sl it looks like this

Screenshot from 2022-03-03 09-40-03

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #23 (fcd0da3) into main (18c2145) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #23   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          2       2           
  Lines         97      98    +1     
=====================================
- Misses        97      98    +1     
Impacted Files Coverage Δ
spectrum_plotter/core.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc3d920...fcd0da3. Read the comment docs.

@shimwell
Copy link
Member

shimwell commented Mar 3, 2022

Tests are passing and changes looks good thanks @py1sl

@shimwell shimwell merged commit d49e7cd into fusion-energy:main Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants