Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

/me fetch failure causing infinite loop #58

Closed
attilah opened this issue Oct 19, 2023 · 1 comment · Fixed by #61
Closed

/me fetch failure causing infinite loop #58

attilah opened this issue Oct 19, 2023 · 1 comment · Fixed by #61
Assignees
Labels
bug Something isn't working

Comments

@attilah
Copy link

attilah commented Oct 19, 2023

/me fetch failure causing infinite loop

Description

After login when no user cookie is present then the user info endpoint is being invoked via a fetch request and if that fetch fails for a reason (CORS, or anything else), and a re-render is triggered, then it will cause an infinite loop (can be tested with the example app, comment out the alert dialog to see it).

Affects versions

Latest

Steps to reproduce

Steps to reproduce the behavior:

  1. Configure a failing userinfo endpoint in the example app
  2. Login to the app

Expected behavior

Have some backoff strategy to stop making the fetch calls and getting information about userinfo failure specifically (because it is a backchannel invocation failure, not a redirect failure) or the ability to pass in a function which can do the userinfo invocation, so the consumers of the SDK has a better control over what to do.

Screenshots

N/A

@mooreds mooreds added the bug Something isn't working label Oct 20, 2023
@mooreds
Copy link
Collaborator

mooreds commented Oct 20, 2023

Thanks for filing this, @attilah

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants