Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create migrations for Django 1.7 and 1.8. #37

Merged
merged 3 commits into from
Jul 20, 2015
Merged

Create migrations for Django 1.7 and 1.8. #37

merged 3 commits into from
Jul 20, 2015

Conversation

jxcl
Copy link
Contributor

@jxcl jxcl commented May 11, 2015

Authtools has no migrations but depends on contrib.auth which has
migrations.

migrations.AlterField(
model_name='user',
name='last_login',
field=models.DateTimeField(null=True, verbose_name='last login', blank=True),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we remove the default too? I guess the default is handled by Django and not the database.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so then nevermind

@rockymeza
Copy link
Contributor

Please add some documentation for how to use the migrations (especially if we weren't using migrations previously). I think you could add it in the changelog.

Thanks,

Alexander Bliskovsky added 2 commits May 13, 2015 10:13
Authtools has no migrations but depends on contrib.auth which has
migrations.
@jxcl
Copy link
Contributor Author

jxcl commented May 13, 2015

@rockymeza done.


$ python manage.py migrate --fake authtools 0001_initial

$ python manage.py migrate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a formatting bug, this is coming up as a blockquote see https://github.com/fusionbox/django-authtools/blob/1.8-support/CHANGES.rst

@rockymeza
Copy link
Contributor

For the record, we need to make another pull request that runs the tests against Django 1.8. However, that is something of a larger endeavor, as we need to figure out what to do since in 1.8 the tests that we were importing are no longer available.

@Wenze
Copy link

Wenze commented Jun 23, 2015

Any idea if/when this will be fixed?

@acatton
Copy link
Contributor

acatton commented Jun 29, 2015

@Wenze we need to import the tests from Django 1.8 into authtools before merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants