-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create migrations for Django 1.7 and 1.8. #37
Conversation
migrations.AlterField( | ||
model_name='user', | ||
name='last_login', | ||
field=models.DateTimeField(null=True, verbose_name='last login', blank=True), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we remove the default too? I guess the default is handled by Django and not the database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so then nevermind
Please add some documentation for how to use the migrations (especially if we weren't using migrations previously). I think you could add it in the changelog. Thanks, |
Authtools has no migrations but depends on contrib.auth which has migrations.
@rockymeza done. |
|
||
$ python manage.py migrate --fake authtools 0001_initial | ||
|
||
$ python manage.py migrate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a formatting bug, this is coming up as a blockquote see https://github.com/fusionbox/django-authtools/blob/1.8-support/CHANGES.rst
For the record, we need to make another pull request that runs the tests against Django 1.8. However, that is something of a larger endeavor, as we need to figure out what to do since in 1.8 the tests that we were importing are no longer available. |
Any idea if/when this will be fixed? |
@Wenze we need to import the tests from Django 1.8 into authtools before merging this. |
Authtools has no migrations but depends on contrib.auth which has
migrations.