Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added first revision of authtool templates #8

Closed
wants to merge 4 commits into from
Closed

Conversation

@@ -0,0 +1 @@
{% load i18n %}{% trans "Account activation on" %} {{ site.name }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a Django setting with a default value?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rockymeza rockymeza mentioned this pull request Aug 16, 2013
{{ form.as_p }}
<input type="submit" value="{% trans 'Change my password' %}">
</form>
{% else %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you dedent this else tag?

@gavinwahl
Copy link
Member

form.as_p?

@rockymeza
Copy link
Contributor

what would you use instead?


{% trans "Please go to the following page and choose a new password:" %}
{% block reset_link %}
{{ protocol }}://{{ domain }}{% url 'password_reset_confirm' uidb64=uid token=token %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work on Django < 1.6. What I was saying is resolve the link in the view and pass it into the context of the email

@aminy
Copy link

aminy commented Feb 15, 2016

Any idea when this will be merged to master?

@gavinwahl
Copy link
Member

@aminy, I don't think there are actually any plans to merge this. In my experience, templates are always specific enough to a project, even within a single company, that you have to override them anyway. Between different versions of django, different base.html's, different preferences of developers, I can't imagine how to make templates that fit everyone's needs.

@0xafbf
Copy link

0xafbf commented Jul 12, 2016

I think some templates would be useful, not for using them but for having a guide to create own templates and for easy testing

@jxcl
Copy link
Contributor

jxcl commented Feb 10, 2020

Closing because this is very old and the Django project has templates you can use as starting points if you need to.

django/contrib/admin/templates/registration/password_change_done.html etc.

@jxcl jxcl closed this Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants