Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Django Form Wizard #24

Merged
merged 1 commit into from Aug 18, 2015
Merged

Does not work with Django Form Wizard #24

merged 1 commit into from Aug 18, 2015

Conversation

rockymeza
Copy link
Contributor

I've tried creating a MultiForm containing two regular forms, but I could not add that one to a regular Django WizardView. Is there another way to make this work?

@rockymeza
Copy link
Contributor

Hi @dirkmoors,

Thanks for bringing this up, I haven't tried using Multiform with the Wizard. I will investigate this.

Could you send me some code to show what you tried? That would help a lot.

Thanks!

@rockymeza
Copy link
Contributor

Hi @dirkmoors,

Here's my attempt at getting this to work. Could you try it out?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 77.76% when pulling 7adac83 on wizardview into a840355 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 77.76% when pulling 7adac83 on wizardview into a840355 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 77.76% when pulling 7adac83 on wizardview into a840355 on master.

@pipermerriam
Copy link
Contributor

👍 on this. Looks good @rockymeza

@frankier
Copy link

It looks like it should actually be possible to provide a reasonable implementation of base_fields, that would at least allow WizardView's introspection to work correctly. See: frankier@e1d1d0a

If I merged this into this PR, and adjusted the docs accordingly, is there any interest in merging this?

@pipermerriam
Copy link
Contributor

@frankier yes, if you want to get this PR updated I'll get it merged and released.

@pipermerriam
Copy link
Contributor

@frankier Actually, I'm going to merge this, and you can just PR in your change independently.

pipermerriam added a commit that referenced this pull request Aug 18, 2015
Does not work with Django Form Wizard
@pipermerriam pipermerriam merged commit c218b6a into master Aug 18, 2015
@pipermerriam pipermerriam deleted the wizardview branch August 18, 2015 19:28
@rockymeza
Copy link
Contributor

Hey @frankier,

thanks for all the interest in betterforms recently. I would love to see your PR get merged, the only thing I want is to have a big stinking warning in the docs about how base_fields is an approximation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants