Deprecated widgy.backbone.render #268
Conversation
BeautifulSoup import is the third version, which was a dependency of django-fusionbox.
This middleware have meen moved to git://github.com:fusionbox/django-fusionbox.git@f6147ab
merged fusionbox#98 * no-fusionbox: Get rid of django-fusionbox in the documentation Remove fusionbox.middleware.GenericTemplateFinderMiddleware dependency Add django argonauts dependency Use widgy queryset on ReviewedVersionCommit Use BeautifulSoup 4 Get rid of fusionbox_tags dependency Switch from django-fusionbox to django-argonauts Copy PhoneNumberField into widgy Add phonenumbers dependency to setup.py for PhoneNumberField Remove dependency from django-fusionbox QuerySetManager Remove fusionbox.core from the demo site INSTALLED_APPS Get rid of fusionbox.behaviors dependency Remove widgy.contrib.replacements module Remove django-fusionbox from requirements.txt file Remove fusionbox internal fabfile Move requirements file in demo site Remove django-fusionbox dependency in setup.py
Until Mezzanine supports Django 1.6
Tabbed Wiget Issue fusionbox#109
…or radio buttons
…ome existing logic to include new ViewList methods
PhoneNumberField unittest - isolated on class
Tests for PhoneNumberField
Form redirection was broken:
* If the form success page doesn't have a “from” parameter, the
success page raises an Error.
(Fixed with the try...except KeyError)
* If the “from” parameter is relative, or if it is something
like '"><img src="'. It raises a NoReverseMatch, because Django
thinks it's a module, and tries to import it. This could lead to a
remote code execution if a user succeed to put a __init__.py file in
the /media/ directory and succeed to import it.
(Fixed by using HttpResponsePermanentRedirect instead of redirect() )
* If the “from” parameter is “http://example.com” widgy will
redirect to example.com, allowing somebody to give links like:
<http://good.example.com/form/success/?from=http://evil.example.com/>.
<http://evil.example.com/> can be fully URL encoded in order to
hide it.
(Fixed by using is_safe_url)
To work around Django bugs in <1.6. Fixes fusionbox#204 for Django >= 1.6. (cherry picked from commit 18582c7) This merges fusionbox#264 and fixes fusionbox#204. Reviewed-By: Antoine Catton <acatton@fusionbox.com>
Changelog typos
widgy/static/widgy/js/nodes/base.js
Outdated
| _.each(this.cssClasses(), this.$el.addClass, this.$el); | ||
|
|
||
| return this; | ||
| // Depricated for renderPromise |
|
Hey @zmetcalf, I like it. I just had some comments in there. Let's get these addressed. Are there any calls to render at all now? If not, we could just remove all of the render methods. That way we can just get rid of the dead code. thoughts? |
zmetcalf
force-pushed
the
deprecate_render
branch
2 times, most recently
from
a0a06bf
to
ac4f4c3
Compare
|
@rockymeza I changed the name of As for returning the |
| }); | ||
|
|
||
| shelf.resizeShelf(); | ||
| $(window).resize(shelf.resizeShelf); |
There was a problem hiding this comment.
right here you need to return shelf.
There was a problem hiding this comment.
you need to return shelf here. Then you can just return promise.then
|
@zmetcalf, there are several places where you need to call |
zmetcalf
force-pushed
the
deprecate_render
branch
from
ac4f4c3
to
8cc4981
Compare
|
@rockymeza, thank you for the help with that. All fixed up I hope! |
|
merged in 638453e |
|
Hey Zach, I unmerged this (seeing as it was only merged for 4 minutes). I found a bug. This broke the visible_drop_targets optimization. I will investigate. |
|
I added a commit, you can see it here: https://github.com/fusionbox/django-widgy/tree/deprecate_render It fixes two bugs that came out of the deprecate render commit:
Can you review my changes and then we'll merge? |
|
Wow, good catch! The fix worked on my end. |
Beat you to it @rockymeza. This is for issue #259.