Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactoring and improvements #438

Merged
merged 7 commits into from
Mar 25, 2020
Merged

Minor refactoring and improvements #438

merged 7 commits into from
Mar 25, 2020

Conversation

skrolikowski
Copy link
Contributor

@skrolikowski skrolikowski commented Mar 20, 2020 •
edited
Loading

What does this implement or fix?

  • Added App\Rules\SecurePassword for a validating passwords across system (preparing for: Ability to set user account password strength standards & requirements #155 ).
  • Updates to unit tests surrounding users.
  • Refactoring Controllers and applying Form Requests.
  • Updated flash errors/success partial to work consistently with Laravel's docs.
  • Added explicit {fieldset} Model Binding.

Does this close any currently open issues?

N/A

  • I have compiled my javascript/scss resources for production, because I don't like submitting hundreds of thousands of new lines of code.

@skrolikowski skrolikowski marked this pull request as ready for review March 25, 2020 18:29
@kaidesu kaidesu merged commit 6ec25b3 into fusioncms:master Mar 25, 2020
@skrolikowski skrolikowski deleted the Test-Refactor branch March 25, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skrolikowski @kaidesu