fix: fix typos and syntax from previous commit

fusioninventory · Sep 28, 2020 · 4e5f4e0 · 4e5f4e0
1 parent 1275168
commit 4e5f4e0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/lib/FusionInventory/Agent/SNMP/MibSupport/Multitech.pm b/lib/FusionInventory/Agent/SNMP/MibSupport/Multitech.pm
@@ -40,7 +40,10 @@ sub getSnmpHostname {
     my $serial = $self->getSerial()
         or return;
 
-    return $self->{MODEL}.'_'.$serial;
+    my $device = $self->device
+        or return;
+
+    return $device->{MODEL}.'_'.$serial;
 }
 
 sub getModel {

diff --git a/lib/FusionInventory/Agent/SNMP/MibSupport/Ricoh.pm b/lib/FusionInventory/Agent/SNMP/MibSupport/Ricoh.pm
@@ -35,6 +35,9 @@ sub getModel {
 sub getSnmpHostname {
     my ($self) = @_;
 
+    my $device = $self->device
+        or return;
+
     my $hostname = getCanonicalString($self->get(hostname));
 
     # Don't override if found hostname is manufacturer+model

diff --git a/lib/FusionInventory/Agent/SNMP/MibSupport/Siemens.pm b/lib/FusionInventory/Agent/SNMP/MibSupport/Siemens.pm
@@ -88,7 +88,7 @@ sub getSnmpHostname {
     return $name if $name;
 
     my $serial = $self->getSerial()
-        or return:
+        or return;
 
     return $serial;
 }