--help output is not an error

fusioninventory-agent

@@ -58,7 +58,7 @@ GetOptions(
     'stdout',
 ) or pod2usage(-verbose => 0);
 
-pod2usage(-verbose => 0) if $options->{help};
+pod2usage(-verbose => 0, -exitstatus => 0) if $options->{help};
 
 if ($options->{version}) {
     print $FusionInventory::Agent::VERSION_STRING . "\n";

fusioninventory-injector

@@ -91,7 +91,7 @@ GetOptions(
 );
 
 $OUTPUT_AUTOFLUSH = 1;
-pod2usage() if $options{help};
+pod2usage(-verbose => 0, -exitstatus => 0) if $options{help};
 
 if ($options{file}) {
     die "file $options{file} does not exist" unless -f $options{file};

t/apps/agent.t

@@ -15,21 +15,21 @@ use Test::More tests => 32;
 my ($content, $out, $err, $rc);
 
 ($out, $err, $rc) = run_agent('--help');
-ok($rc == 2, '--help exit status');
+ok($rc == 0, '--help exit status');
+is($err, '', '--help stderr');
 like(
-    $err,
+    $out,
     qr/^Usage:/,
-    '--help stderr'
+    '--help stdout'
 );
-is($out, '', '--help stdin');
 
 ($out, $err, $rc) = run_agent('--version');
 ok($rc == 0, '--version exit status');
 is($err, '', '--version stderr');
 like(
     $out,
     qr/^FusionInventory Agent/,
-    '--version stdin'
+    '--version stdout'
 );
 
 my $tmpFile = tmpnam();
@@ -58,7 +58,7 @@ like(
     qr/No target defined/,
     'no target stderr'
 );
-is($out, '', 'no target stdin');
+is($out, '', 'no target stdout');
 
 my $base_options = "--stdout --debug --no-task ocsdeploy,wakeonlan,snmpquery,netdiscovery";
 

t/apps/injector.t

@@ -11,14 +11,13 @@ use Test::More tests => 3;
 my ($out, $err, $rc);
 
 ($out, $err, $rc) = run_injector('--help');
-ok($rc == 2, '--help exit status');
+ok($rc == 0, '--help exit status');
+is($err, '', '--help stderr');
 like(
-    $err,
-    qr/^Usage/,
-    '--help'
+    $out,
+    qr/^Usage:/,
+    '--help stdout'
 );
-is($out, '', '--help stdin');
-
 
 sub run_injector {
     my ($args) = @_;