Remove dead code in tasks. Translation strings that are not yet trans… #2394
Conversation
wawax
commented
Dec 27, 2017
•
wawax
commented
- Clean unused methods
- Use constants for tasks related states
- Translate hardcoded strings in tasks logs
…lated. Use task constants
| $pfImportExport = new PluginFusioninventorySnmpmodelImportExport(); | ||
| $errors .= $pfImportExport->import_netdiscovery($a_CONTENT, $p_DEVICEID); | ||
| if (isset($a_CONTENT['AGENT']['END'])) { | ||
| if ((isset($a_CONTENT['DICO'])) AND ($a_CONTENT['DICO'] == "REQUEST")) { |
There was a problem hiding this comment.
I really do not know how to be sure this is still used
There was a problem hiding this comment.
it was an old behavior of the agent:it had an auto update mechanism for network discovery mapping file. If the agent had a outdated version, the server would send a message to stop the process. Next time, the server would send the new file to the agent and the process could continue.
If was complicated and frustrating for the user, it has been removed a long time ago.
There was a problem hiding this comment.
OK, thank you for the explanations :)
inc/taskjob.class.php
Outdated
| $pfAgentmodule = new PluginFusioninventoryAgentmodule(); | ||
| $array1 = $pfAgentmodule->getAgentsCanDo(strtoupper($module)); |
There was a problem hiding this comment.
Hum... Maybe the original way was better for perfs
There was a problem hiding this comment.
you're right I've reverted this modification
|
|
||
| case 3: |
There was a problem hiding this comment.
I guess this is also something that is no longer used now?
There was a problem hiding this comment.
yes, this taskjoblog state has never been used...
| @@ -530,19 +447,18 @@ function dropdownAction($myname, $actiontype, $method, $actiontypeid, $value=0, | |||
| * @return array [id integed agent id] => $name value agent name | |||
| */ | |||
| function getAgents($module) { | |||
|
|
|||
| $array = []; | |||
| $array[".1"] = " ".__('Auto managenement dynamic of agents', 'fusioninventory'); | |||
There was a problem hiding this comment.
Another old thing not longer used?
There was a problem hiding this comment.
yes, it was an old task feature that has been deprecated during the task rework
#2394) * Remove dead code in tasks. * Translation for strings that are not yet translated. * Use task constants
