This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Fix footer because too intruisive. closes #1938 #1950
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trasher
suggested changes
Oct 30, 2016
@@ -0,0 +1,16 @@ | |||
var fifooter = "<div id='footer'> \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There still is a duplicate ID, they must be unique.
Why not just add the a
content in the last cell of the #footer
with a <br/>
?
Because there is a CSS on the id footer |
Take a look with:
Does that look ok for you? Do not seem the existing CSS cause any issue. |
I've fixed with your recommandation ;) |
trasher
approved these changes
Nov 2, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat ;)
Unit tests are failing, but this is not due to footer changes; so: approved! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.