Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Fix footer because too intruisive. closes #1938 #1950

Merged
merged 3 commits into from Nov 4, 2016

Conversation

ddurieux
Copy link
Member

@ddurieux ddurieux commented Oct 30, 2016

No description provided.

@coveralls
Copy link

coveralls commented Oct 30, 2016

Coverage Status

Coverage decreased (-24.2%) to 7.222% when pulling 134885c on ddurieux:fix-#1938 into baacaeb on fusioninventory:master.

@@ -0,0 +1,16 @@
var fifooter = "<div id='footer'> \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There still is a duplicate ID, they must be unique.

Why not just add the a content in the last cell of the #footer with a <br/>?

@ddurieux
Copy link
Member Author

Because there is a CSS on the id footer

@trasher
Copy link
Contributor

trasher commented Oct 30, 2016

Take a look with:

diff --git a/js/footer.js b/js/footer.js
index b7fe606..ff4d356 100644
--- a/js/footer.js
+++ b/js/footer.js
@@ -1,16 +1,12 @@
-var fifooter = "<div id='footer'> \
-<table width='100%'>  \
-<tr> \
-<td class='right'> \
+var fifooter = "<br/> \
 <a class='copyright' href='http://fusioninventory.org/'> \
 FusionInventory 9.1+1.0 - Copyleft \
 <span style='display:inline-block;transform: rotate(180deg);font-size: 12px;'>&copy;</span> \
 2010-2016 by FusionInventory Team \
-</a> \
-</td> \
-</tr> \
-</table> \
-</div>"
+</a>";

-$(window).bind("load", function() { $("#footer").after(fifooter); })
+$(window).bind("load", function() {
+   $('#footer').css('height', 'auto');
+   $("#footer td.right").append(fifooter);
+});

Does that look ok for you? Do not seem the existing CSS cause any issue.

@ddurieux
Copy link
Member Author

ddurieux commented Nov 2, 2016

I've fixed with your recommandation ;)

@coveralls
Copy link

coveralls commented Nov 2, 2016

Coverage Status

Coverage decreased (-0.07%) to 31.396% when pulling cb22f97 on ddurieux:fix-#1938 into baacaeb on fusioninventory:master.

Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat ;)

@trasher
Copy link
Contributor

trasher commented Nov 2, 2016

Unit tests are failing, but this is not due to footer changes; so: approved!

@coveralls
Copy link

coveralls commented Nov 2, 2016

Coverage Status

Coverage decreased (-0.0002%) to 31.407% when pulling 492fb9e on ddurieux:fix-#1938 into babd78c on fusioninventory:master.

@coveralls
Copy link

coveralls commented Nov 4, 2016

Coverage Status

Coverage increased (+29.5%) to 60.886% when pulling 87f0992 on ddurieux:fix-#1938 into babd78c on fusioninventory:master.

@trasher trasher merged commit cd4860f into fusioninventory:master Nov 4, 2016
@ddurieux ddurieux deleted the fix-#1938 branch November 6, 2016 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants