This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Deploy by tech #2109
Merged
Deploy by tech #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orthagh
force-pushed
the
deploy_by_tech
branch
3 times, most recently
from
fe9e096
to
ff148bb
Compare
orthagh
suggested changes
Apr 11, 2017
inc/deploypackage.class.php
Outdated
| $packages_used = $this->getMyDepoyPackages($my_packages, $users_id); | ||
|
|
||
| $packages = $this->canUserDeploySelf(); | ||
| //Get packages that a the user can deploy | ||
| $packages = $this->canUserDeploySelf(); |
There was a problem hiding this comment.
clear spaces before '=', i don't see any lines where this alignment is needed
inc/deploypackage.class.php
Outdated
| 'name' => '[deploy on demand] '.$this->fields['name'], | ||
| 'entities_id' => $computer->fields['entities_id'], | ||
| 'reprepare_if_successful' => 0, | ||
| 'is_deploy_on_demand' => 1 |
inc/deploypackage.class.php
Outdated
| ); | ||
|
|
||
| //Enable the task | ||
| $input = ['id' => $tasks_id, 'is_active' => 1]; |
There was a problem hiding this comment.
Why not activating the task on the previous "->add($input)"
| $a_menu[6]['link'] = $CFG_GLPI['root_doc']. | ||
| "/plugins/fusioninventory/front/ruledictionnarycomputerarch.php"; | ||
| } | ||
|
|
There was a problem hiding this comment.
You removed computer architectures rules from menu ?
There was a problem hiding this comment.
yes, not needed anymore as it's been transfered into glpi core since 9.1
inc/task.class.php
Outdated
| return array('description' => __('FusionInventory task scheduler')); | ||
|
|
||
| case 'cleanOnDemand' : | ||
| return array('description' => __('Clean on deman deployment tasks')); |
remove fi at ant eol
…ed. Update unit tests
orthagh
force-pushed
the
deploy_by_tech
branch
5 times, most recently
from
5c07a85
to
67e9b05
Compare
orthagh
approved these changes
Apr 12, 2017
orthagh
pushed a commit
that referenced
this pull request
Apr 12, 2017
* Add right for one time deployment * Remove unused code & menus * Work on generization * Factorize code * fActorize code * Continue rename Deploy on demand task * Add an option to force a local or remote agent wakeup * Add an option to not wakeup the agent * Add crontasj to clean on demand tasks if needed * Split crontask in two to be able to test it * Fix unit tests * Update on demande deploy tests * wait a little time for local wakeup * More understandable wakeup messages * remove coverage for php7.1 remove fi at ant eol * Do not propose packages to deploy when agent has no deploy task enabled. Update unit tests * fix id used in package edition (we change package not orders) should fix #2019 * fix tests fix tests fix tests fix tests CS tests fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to deploy packages on demand, not only for a self service person.
Add informations about packages available and being installed in the task tab of a computer.
Also add the possiblity, when user is using the standard interface to select if wakeup should be local (calling the agent as 127.0.0.1) or remote, from the server.