This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Add an option to enable monitor serialnumber partial matching #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Option is disabled by default
trasher
reviewed
Sep 19, 2019
|
You have a cs issue, could you fix plase: |
orthagh
approved these changes
Sep 20, 2019
trasher
approved these changes
Sep 20, 2019
trasher
pushed a commit
that referenced
this pull request
Sep 20, 2019
* Add an option to enable monitor serialnumber partial matching Option is disabled by default * Try monitor serial partial match only if the serial number has at least 4 chars
trasher
pushed a commit
that referenced
this pull request
Sep 20, 2019
* Add an option to enable monitor serialnumber partial matching Option is disabled by default * Try monitor serial partial match only if the serial number has at least 4 chars
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option is disabled by default
As monitor serial numbers are very badly handled by manufacturers in EDID block, the one found by the agent is often partly the one visible on the device itself. When people manually adds monitors in its stock, it will of course put as serial number the one found on device itself or on its packaging.
So this option could be enabled when people starts to see duplicated monitors with serial numbers partially different. This won't merge duplicated entries, so people will always have to delete one of the duplicated entries (the one from the dynamic inventory as first choice).