This repository has been archived by the owner on May 17, 2019. It is now read-only.
Add jest support, since Fusion.js uses it #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Currently this is for folks who use expect() without the assertion helper that we pass into tests in fusion-test-utils, correct?
I think we should only do this if we remove the assertion parameter from fusion-test-utils. Let's just recommend one way of testing/making assertions?
|
See also fusionjs/fusion-cli#337 |
KevinGrandon
approved these changes
Jul 26, 2018
AlexMSmithCA
added a commit
that referenced
this pull request
Jul 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently using the plain Jest API in Fusion.js tests causes lint errors:
Since we advertise Jest as being integrated into Fusion, we should make lint work with it.