This repository has been archived by the owner on May 17, 2019. It is now read-only.
Switch to parser-inserted scripts, fix script preloading for legacy bundles #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtsao
force-pushed
the
parser-inserted-scripts
branch
2 times, most recently
from
b3ae2b2
to
a2d3344
Compare
rtsao
force-pushed
the
parser-inserted-scripts
branch
from
a2d3344
to
a71bee7
Compare
lhorie
approved these changes
Nov 8, 2018
|
!merge |
angus-c
reviewed
Nov 8, 2018
| browser.version.startsWith('10.1'); | ||
|
|
||
| // Safari 10.1 supports modules but not `nomodule` attribute. | ||
| if (!isSafari10_1) { |
There was a problem hiding this comment.
Might be reading this wrong but it looks like non-edge, non-safari 10.1 browsers get both modern and legacy bundles in criticalChunkScripts
There was a problem hiding this comment.
Yep, that's exactly as intended.
Browsers that do not support <script type="module"> will simply ignore them. And all browsers that support <script type="module"> will ignore <script nomodule> scripts, except for Safari 10.1, which will ignore nomodule thereby downloading and executing both type="module" and nomodule scripts. So exclusively for Safari 10.1, only <script type="module"> should be sent.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes script preloading in legacy browsers
Replaces dynamic script loading with scripts in markup to ensure the scripts are marked as parser-inserted. Not all browsers respect
deferattributes for scripts that are not marked as parser-inserted. This caused problems in FF/Edge. https://html.spec.whatwg.org/multipage/scripting.htmlnomodulesupport check with server-side UA check for Safari 10.1 (to prevent double script download/execution)