Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Do not override default webpack node polyfills settings #634

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions build/get-webpack-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -580,12 +580,6 @@ if (process.env.NODE_ENV && process.env.NODE_ENV !== '${env}') {
function getNodeConfig(runtime) {
const emptyForWeb = runtime === 'client' ? 'empty' : false;
return {
// Polyfilling process involves lots of cruft. Better to explicitly inline env value statically
process: false,
// We definitely don't want automatic Buffer polyfills. This should be explicit and in userland code
Buffer: false,
// We definitely don't want automatic setImmediate polyfills. This should be explicit and in userland code
setImmediate: false,
// We want these to resolve to the original file source location, not the compiled location
// in the future, we may want to consider using `import.meta`
__filename: true,
Expand Down