This repository has been archived by the owner on May 17, 2019. It is now read-only.
Fix issue with errors being swallowed in child compilations #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,15 +26,39 @@ const { | |||
| const mergeChunkMetadata = require('./merge-chunk-metadata'); | |||
| const loadFusionRC = require('./load-fusionrc.js'); | |||
|
|
|||
| function getErrors(info) { | |||
| let errors = [].concat(info.errors); | |||
| if (info.children.length) { | |||
AlexMSmithCA
previously approved these changes
Mar 25, 2019
test/e2e/missing-module/test.js
Outdated
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| const path = require('path'); | |||
| const testEnvs = require('../errors.js'); | |||
| const t = require('assert'); | |||
There was a problem hiding this comment.
(Minor) linter is complaining that this is never used:
$ eslint .
--
| Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration .
| { parser: "babylon" } is deprecated; we now treat it as { parser: "babel" }.
|
| /fusion-cli/test/e2e/missing-module/test.js
| 6:7 error 't' is assigned a value but never used no-unused-vars
|
| ✖ 1 problem (1 error, 0 warnings)
rtsao
approved these changes
Mar 26, 2019
|
!merge |
|
Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1793 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we get error logs whenever a compilation fails. It also adds a regression test
in the form of snapshots of the logger calls.