This repository has been archived by the owner on May 17, 2019. It is now read-only.
Add render benchmark to performance API #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
=========================================
- Coverage 92.25% 91.7% -0.55%
=========================================
Files 18 18
Lines 413 410 -3
Branches 79 77 -2
=========================================
- Hits 381 376 -5
- Misses 17 18 +1
- Partials 15 16 +1
Continue to review full report at Codecov.
|
KevinGrandon
approved these changes
Jun 29, 2018
There was a problem hiding this comment.
I know this is only one line, but am a bit worried about slowly adding what might be perceived as runtime bloat to our open source template. Wondering if we could either enable this as a feature flag in the future, or potentially some token that folks can override through the DI system.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.