Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Don't render when ctx.respond is false #247

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

ganemone
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #247 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #247   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files          18       18           
  Lines         413      413           
  Branches       79       79           
=======================================
  Hits          381      381           
  Misses         17       17           
  Partials       15       15
Impacted Files Coverage Δ
src/plugins/ssr.js 94.36% <100%> (ø) ⬆️
src/plugins/server-renderer.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d79c1ca...021ee77. Read the comment docs.

Copy link
Contributor

@KevinGrandon KevinGrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add documentation for this in the README?

https://github.com/fusionjs/fusion-core#context

@KevinGrandon KevinGrandon changed the title Dont render when ctx.respond is false Don't render when ctx.respond is false Jun 29, 2018
@ganemone
Copy link
Contributor Author

This is sorta a crazy not-recommended feature so I think it is okay leaving it undocumented for now

@ganemone
Copy link
Contributor Author

!merge

@old-fusion-bot old-fusion-bot bot merged commit a3e1868 into fusionjs:master Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants