Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Change script order, add fusion-cli peer dependency #257

Merged
merged 2 commits into from
Aug 1, 2018

Conversation

rtsao
Copy link
Member

@rtsao rtsao commented Aug 1, 2018

  • Moves execution of critical (preloaded) async chunks before "sync" chunks
  • Enforces usage of fusion-cli version 1.2.2 or newer (i.e. versions of fusion-cli using webpack 4)

This will eventually allow for the removal of our custom chunk preloading code (needed in webpack 3 and older)

@rtsao rtsao changed the title Change script order Change script order, add fusion-cli peerDependency Aug 1, 2018
@rtsao rtsao changed the title Change script order, add fusion-cli peerDependency Change script order, add fusion-cli peer dependency Aug 1, 2018
@codecov
Copy link

codecov bot commented Aug 1, 2018

Codecov Report

Merging #257 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files          18       18           
  Lines         413      413           
  Branches       79       79           
=======================================
  Hits          381      381           
  Misses         17       17           
  Partials       15       15
Impacted Files Coverage Δ
src/plugins/ssr.js 94.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cc3b16...2a085d7. Read the comment docs.

@rtsao
Copy link
Member Author

rtsao commented Aug 1, 2018

!merge

@old-fusion-bot old-fusion-bot bot merged commit b5fd153 into master Aug 1, 2018
@AlexMSmithCA AlexMSmithCA mentioned this pull request Aug 20, 2018
@AlexMSmithCA AlexMSmithCA mentioned this pull request Aug 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants