Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Add CSP nonces to chuck script tags #269

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

dennisgl
Copy link
Contributor

CSP nonces were missing for initial chunk script tags, this violates CSP in strict-dynamic mode.

@dennisgl dennisgl self-assigned this Aug 23, 2018
@dennisgl dennisgl changed the title add CSP nonces to chuck script tags Add CSP nonces to chuck script tags Aug 23, 2018
@codecov
Copy link

codecov bot commented Aug 23, 2018

Codecov Report

Merging #269 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #269   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files          18       18           
  Lines         413      413           
  Branches       79       79           
=======================================
  Hits          381      381           
  Misses         17       17           
  Partials       15       15
Impacted Files Coverage Δ
src/plugins/ssr.js 94.36% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf95e1...420a963. Read the comment docs.

@lhorie
Copy link
Contributor

lhorie commented Aug 23, 2018

Nice catch

@dennisgl
Copy link
Contributor Author

!merge

@old-fusion-bot old-fusion-bot bot merged commit 2576952 into fusionjs:master Aug 23, 2018
@AlexMSmithCA AlexMSmithCA mentioned this pull request Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants