Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Upgrade flow-bin to latest and fixes #356

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Upgrade flow-bin to latest and fixes #356

merged 2 commits into from
Feb 5, 2019

Conversation

AlexMSmithCA
Copy link
Member

Upgrades flow-bin to v0.92.0 and resolves the following complaint:

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ src/__tests__/sanitization.node.js:36:12

Cannot call null.toString because property toString is missing in null [1].

     33│   const userData = '<malicious data="" />';
     34│   const value = html`
     35│     <div>${userData}</div>
 [1] 36│     ${null.toString()}
     37│   `;
     38│   t.equals(typeof value, 'object');
     39│   t.equals(



Found 1 error

@AlexMSmithCA AlexMSmithCA self-assigned this Feb 5, 2019
@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #356 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #356   +/-   ##
======================================
  Coverage    93.2%   93.2%           
======================================
  Files          18      18           
  Lines         456     456           
  Branches       91      91           
======================================
  Hits          425     425           
  Misses         17      17           
  Partials       14      14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65818f2...41c8d99. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #356 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #356   +/-   ##
======================================
  Coverage    93.2%   93.2%           
======================================
  Files          18      18           
  Lines         456     456           
  Branches       91      91           
======================================
  Hits          425     425           
  Misses         17      17           
  Partials       14      14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65818f2...41c8d99. Read the comment docs.

@AlexMSmithCA
Copy link
Member Author

!merge

@old-fusion-bot old-fusion-bot bot merged commit 10ceec0 into fusionjs:master Feb 5, 2019
@albertywu albertywu mentioned this pull request Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants