Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Upgrade flow to 0.93.0 #358

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Upgrade flow to 0.93.0 #358

merged 2 commits into from
Feb 14, 2019

Conversation

lhorie
Copy link
Contributor

@lhorie lhorie commented Feb 14, 2019

Fixes a koa flow-typed def regression

Copy link
Contributor

@KevinGrandon KevinGrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but seems like eslint is failing here. I think previously it looks like we must've run eslint --fix and added // eslint-disable-next-line. That's not quite ideal, so I suppose we should skip the flow-typed folder if possible.

@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #358 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #358   +/-   ##
======================================
  Coverage    93.2%   93.2%           
======================================
  Files          18      18           
  Lines         456     456           
  Branches       91      91           
======================================
  Hits          425     425           
  Misses         17      17           
  Partials       14      14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a907591...412b894. Read the comment docs.

@lhorie
Copy link
Contributor Author

lhorie commented Feb 14, 2019

That's weird. This shouldn't have passed CI before..

Fixed now

@lhorie lhorie merged commit 7094e23 into master Feb 14, 2019
@old-fusion-bot
Copy link

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1482

@old-fusion-bot old-fusion-bot bot deleted the flow branch February 14, 2019 18:51
@AlexMSmithCA AlexMSmithCA mentioned this pull request Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants