Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Fix SSR Decider for Bots #371

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Fix SSR Decider for Bots #371

merged 1 commit into from
Mar 20, 2019

Conversation

ganemone
Copy link
Contributor

Previously we were returning true from the SSRDecider for all requests with a
user agent matching a bot. This caused issues when handling non GET routes.
This updates the logic to also check for the request method === GET.

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #371 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          18       18           
  Lines         458      458           
  Branches       91       91           
=======================================
  Hits          427      427           
  Misses         17       17           
  Partials       14       14
Impacted Files Coverage Δ
src/plugins/ssr.js 91.17% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ef36ea...0530311. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #371 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          18       18           
  Lines         458      458           
  Branches       91       91           
=======================================
  Hits          427      427           
  Misses         17       17           
  Partials       14       14
Impacted Files Coverage Δ
src/plugins/ssr.js 91.17% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ef36ea...0530311. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #371 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          18       18           
  Lines         458      458           
  Branches       91       91           
=======================================
  Hits          427      427           
  Misses         17       17           
  Partials       14       14
Impacted Files Coverage Δ
src/plugins/ssr.js 91.17% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ef36ea...0530311. Read the comment docs.

@ganemone
Copy link
Contributor Author

!merge

@old-fusion-bot old-fusion-bot bot merged commit a4877a4 into fusionjs:master Mar 20, 2019
@old-fusion-bot
Copy link

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1760

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants