This repository has been archived by the owner on May 17, 2019. It is now read-only.
Add font-display: fallback to font faces
#130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angus-c
force-pushed
the
font-display
branch
from
3022795
to
68e9f4b
Compare
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
=======================================
Coverage 49.21% 49.21%
=======================================
Files 9 9
Lines 128 128
Branches 21 21
=======================================
Hits 63 63
Misses 65 65
Continue to review full report at Codecov.
|
rtsao
approved these changes
Nov 14, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #131
This allows developers to optionally skip withFontLoading HOC in favor of just adding fontFamily in styletron definition. It is a workaround for #108, pending a refactor of the HOC API.
Note: where font-display is not supported (currently Edge, Android plus older browsers) skipping the HOC may result in some old fashioned FOIC and FOUT, though this can be minimized by configuring for maximum preload (set
preloadDepthto 0 insrc/font/config.js)