-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
@KevinGrandon @ganemone ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, we should probably get a few flow fixtures in this app to ensure it works into the future. We can do that out of band though.
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 93.33% 96.42% +3.09%
==========================================
Files 2 2
Lines 30 28 -2
Branches 5 5
==========================================
- Hits 28 27 -1
+ Partials 2 1 -1
Continue to review full report at Codecov.
|
Bump @KevinGrandon @ganemone |
(agreed on the flow fixtures... kinda needs to be an e2e test for some of the underlying fusion-rpc stuff though) |
!merge |
Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1729 |
I incorrectly made
ownProps
a Maybe type in #190. It should be Object at the very least, or preferably pass along the actual Props type (see https://flow.org/en/docs/react/hoc/)I also cleaned up the default argument for
propName
so that flow wouldn't complain.