This repository has been archived by the owner on May 17, 2019. It is now read-only.
Add initial unit tests #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that packages with no tests fail to build with the latest create-universal-package. Adding a simple test to fix this.
|
Hmm, bug... or feature? 😅 |
Hah, doesn't matter to me. I think jest recently started failing when there was no tests found. Guess there should at least be some kind of error message. Seems that this is failing to build for some reason, not sure why yet. |
|
Strange, at least locally it builds fine (after upgrading cup) |
Ah, problem was that the Dockerfile had an optimized layer caching strategy (only add package info and cache node_modules). With CUP we transpile after building which is good and bad, but doesn't allow us to have super-efficient dockerfiles. Still need to figure out the best strategy here. |
lhorie
approved these changes
Feb 6, 2018
|
!merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that packages with no tests fail to build with the latest create-universal-package. Adding a simple test to fix this.