Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fusion-test-utils#103] Add Flow type definitions for node-mocks-http to improve Flow coverage #253

Open
chrisdothtml opened this issue May 9, 2019 · 0 comments

Comments

@chrisdothtml
Copy link
Member

chrisdothtml commented May 9, 2019

This issue was migrated from fusionjs/fusion-test-utils#103 and was originally reported by @AlexMSmithCA.


Type of issue

Missing Flow type definitions

Description

src/mock-context.js has low Flow type coverage due to missing type definitions for node-mocks-http.

Current behavior

Low Flow coverage

Expected behavior

100% Flow coverage

Steps to reproduce

  1. npm install -g flow-coverage-report
  2. flow-coverage-report -i 'src/**/*.js' -i 'src/**/*.jsx' -x 'src/test/**' -t html -t json -t text --threshold 90

Your environment

  • fusion-test-utils version: v1.0.2

  • Node.js version (node --version): v8.10.0

  • npm version (npm --version): v5.8.0

  • Operating System: macOS High SIerra v10.13.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant