Add initial implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtsao
previously approved these changes
Nov 3, 2017
rtsao
reviewed
Nov 3, 2017
.eslintrc.js
Outdated
| rules: { | ||
| 'no-unused-vars': [ | ||
| 'error', | ||
| {vars: 'all', args: 'none', varsIgnorePattern: '^h$'}, |
There was a problem hiding this comment.
Is this meant to be here? I assume this has to do with JSX?
There was a problem hiding this comment.
I think it might be an old config. It seems to be a bad copy-paste from some preact thing. I'll get rid of it so it's consistent with other eslintrc's
ganemone
approved these changes
Nov 3, 2017
ganemone
approved these changes
Nov 3, 2017
ganemone
previously approved these changes
Nov 3, 2017
ganemone
approved these changes
Nov 3, 2017
|
!merge |
rtsao
reviewed
Nov 3, 2017
|
|
||
| --- | ||
|
|
||
| ### API |
There was a problem hiding this comment.
Honestly I think we should maybe not document it at all. I'm not convinced we want to expose this interface
There was a problem hiding this comment.
my 2 cents: document, and if we change it, do it formally via a changelog/version bump
UberOpenSourceBot
pushed a commit
that referenced
this pull request
Sep 1, 2021
This fixes an issue where stack traces where pointing to a single `server-main.js` file, instead of respective source file in production logs. `cheap-*` devtool can not be used with minimizers, as it does not include column mappings (see [#1](https://github.com/webpack-contrib/terser-webpack-plugin#note-about-source-maps) [#2](webpack/webpack#4176 (comment)))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2