Update provider plugin to create middleware idempotent #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simulation tests will currently call middleware functions several times in a row. This middleware fails due to changing originalMiddleware, and is not idempotent. This should allow us to call this middleware several times with the same result. The issue is seen in the simulation tests added here: fusionjs/fusion-cli#302
…evinGrandon/fusion-react into KevinGrandon-idempotent-middleware-handling
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 83.01% 90.38% +7.36%
==========================================
Files 6 6
Lines 53 52 -1
Branches 11 11
==========================================
+ Hits 44 47 +3
+ Misses 6 4 -2
+ Partials 3 1 -2
Continue to review full report at Codecov.
|
|
Link to task with description of what error/issue you would see in your app |
dennisgl
approved these changes
Apr 4, 2018
AlexMSmithCA
approved these changes
Apr 4, 2018
|
!merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104