Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call prepare in browser #234

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Call prepare in browser #234

merged 1 commit into from
Mar 4, 2019

Conversation

lhorie
Copy link
Contributor

@lhorie lhorie commented Mar 4, 2019

This fixes a regression in fusion-plugin-rpc-redux-react tests.

As per internal discussion, the prepare call was removed in browser code path because it was assumed to no longer be needed, but this assumption only took into consideration bundle splitting, and not generic usage of prepared. Not calling prepare in browser effectively treats prepared as {defer: true} on the client always.

@lhorie lhorie added the bugfix label Mar 4, 2019
@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@648044c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #234   +/-   ##
=========================================
  Coverage          ?   75.09%           
=========================================
  Files             ?       13           
  Lines             ?      261           
  Branches          ?       55           
=========================================
  Hits              ?      196           
  Misses            ?       48           
  Partials          ?       17
Impacted Files Coverage Δ
src/index.js 71.42% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 648044c...fd43576. Read the comment docs.

@lhorie lhorie merged commit c61afa7 into master Mar 4, 2019
@old-fusion-bot
Copy link

old-fusion-bot bot commented Mar 4, 2019

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1639

@old-fusion-bot old-fusion-bot bot deleted the browser-prepare branch March 4, 2019 22:03
This was referenced Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants