Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prepare context #237

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Add prepare context #237

merged 1 commit into from
Mar 5, 2019

Conversation

rtsao
Copy link
Member

@rtsao rtsao commented Mar 5, 2019

This is needed by the react-router plugin now that client-side prepare is run again

@rtsao rtsao added the bugfix label Mar 5, 2019
@rtsao rtsao changed the title Add back prepare context Add prepare context Mar 5, 2019
@rtsao rtsao requested a review from lhorie March 5, 2019 00:53
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #237 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #237      +/-   ##
=========================================
- Coverage   75.09%   74.8%   -0.29%     
=========================================
  Files          13      13              
  Lines         261     262       +1     
  Branches       55      55              
=========================================
  Hits          196     196              
- Misses         48      49       +1     
  Partials       17      17
Impacted Files Coverage Δ
src/async/prepare.js 90.47% <0%> (-2.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 935680c...10f5a4b. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #237 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #237      +/-   ##
=========================================
- Coverage   75.09%   74.8%   -0.29%     
=========================================
  Files          13      13              
  Lines         261     262       +1     
  Branches       55      55              
=========================================
  Hits          196     196              
- Misses         48      49       +1     
  Partials       17      17
Impacted Files Coverage Δ
src/async/prepare.js 90.47% <0%> (-2.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 935680c...10f5a4b. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 5, 2019 •
edited
Loading

Codecov Report

Merging #237 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #237      +/-   ##
=========================================
- Coverage   75.09%   74.8%   -0.29%     
=========================================
  Files          13      13              
  Lines         261     262       +1     
  Branches       55      55              
=========================================
  Hits          196     196              
- Misses         48      49       +1     
  Partials       17      17
Impacted Files Coverage Δ
src/async/prepare.js 90.47% <0%> (-2.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 935680c...10f5a4b. Read the comment docs.

lhorie
lhorie reviewed Mar 5, 2019
View reviewed changes
src/async/prepare.js
@@ -80,6 +81,7 @@ export default function prepare(element: any) {
}
PrepareContextProvider.childContextTypes = {
__PREPARE_STATE__: () => {},
__IS_PREPARE__: () => {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be false?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is context types, which should be a prop type function. But rather than use that, a noop function suffices instead of using a real prop type.

@lhorie lhorie merged commit 062a1b4 into master Mar 5, 2019
@old-fusion-bot
Copy link

old-fusion-bot bot commented Mar 5, 2019

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1656

@old-fusion-bot old-fusion-bot bot deleted the rtsao-patch-1 branch March 5, 2019 01:07
@AlexMSmithCA AlexMSmithCA mentioned this pull request Mar 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhorie lhorie lhorie approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rtsao @lhorie