Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate eslint packages for Typescript and Flowtype #723

Closed

Conversation

ajbogh
Copy link
Contributor

@ajbogh ajbogh commented Jan 28, 2020

See PR #720

Added separate packages for Typescript and Flowtype eslint rules.

@ajbogh ajbogh changed the title Added separate eslint packages for Typescript and Flowtype. Added separate eslint packages for Typescript and Flowtype Jan 28, 2020
@ajbogh ajbogh changed the title Added separate eslint packages for Typescript and Flowtype Add separate eslint packages for Typescript and Flowtype Jan 28, 2020
@ajbogh
Copy link
Contributor Author

ajbogh commented Jan 28, 2020

This PR can be merged without incidence due to it being new code.

#720 should not be merged until this PR is approved and merged first AND a codemod is available for internal projects. It's recommended that eslint-config-fusion use a major version bump when that time comes.

lhorie
lhorie previously approved these changes Jan 29, 2020
Copy link
Member

@chrisdothtml chrisdothtml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these!

@chrisdothtml
Copy link
Member

!import

@fusionjs-sync-bot
Copy link

This pull request has been imported. If you have access to the parent repo, you can view the imported change here.

UberOpenSourceBot pushed a commit that referenced this pull request Jan 29, 2020
#723

See PR #720

Added separate packages for Typescript and Flowtype eslint rules.

Co-authored-by: Chris Deacy <chrisdothtml@gmail.com>
Co-authored-by: Chris Deacy <deacy@uber.com>
@fusionjs-sync-bot
Copy link

This pull request was landed via 744e5da.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants