Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1372002 - Set attached subscriptions to 0 if input is not valid. #1238

Merged
merged 1 commit into from Sep 27, 2016
Merged

1372002 - Set attached subscriptions to 0 if input is not valid. #1238

merged 1 commit into from Sep 27, 2016

Conversation

cfchase
Copy link
Contributor

@cfchase cfchase commented Sep 26, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.35% when pulling 9f0d4c6 on cfchase:valid-sub-attach into 1ea2f3f on fusor:master.

if (this.get('isQtyInValid')) {
this.set('subscription.qtyToAttach', this.get('subscription.qtyAvailable') );
if (!this.get('isQtyValid')) {
this.set('subscription.qtyToAttach', 0 );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cfchase, I understand the rational of this and agree.

@isratrade
Copy link
Contributor

ACK

@isratrade isratrade merged commit eff6120 into fusor:master Sep 27, 2016
@cfchase cfchase deleted the valid-sub-attach branch October 7, 2016 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants