Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep track of OCP master_lb in database, DRY up OCP deployment parsing #1377

Merged
merged 2 commits into from
Feb 17, 2017
Merged

Keep track of OCP master_lb in database, DRY up OCP deployment parsing #1377

merged 2 commits into from
Feb 17, 2017

Conversation

djwhatle
Copy link
Member

@djwhatle djwhatle commented Feb 16, 2017 •
edited

  • Track master load-balancer host ID on Deployment object for use as a CFME provider
  • Move duplicated OCP parse_deployment methods into a util class

@djwhatle
Copy link
Member Author

djwhatle commented Feb 16, 2017 •
edited

Verified working with RHV self-hosted (2 hypervisors), OCP-HA, CFME. At the end of the deploy, hello-openshift app was curl-able from route, OCP provider was set properly in CFME and was successfully pulling data.

@djwhatle djwhatle changed the title Keep track of OCP master load balancer in Deployment model Keep track of OCP master in database, DRY up OCP deployment parsing Feb 17, 2017
@djwhatle djwhatle changed the title Keep track of OCP master in database, DRY up OCP deployment parsing Keep track of OCP master_lb in database, DRY up OCP deployment parsing Feb 17, 2017
@fabianvf
Copy link
Contributor

nice work, ACK

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 74.754% when pulling 5978b6a on djwhatle:fix_master_lb_inconsistency into ec6406f on fusor:master.

@djwhatle djwhatle merged commit 1dc68e2 into fusor:master Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djwhatle @fabianvf @coveralls