1334502 - Fix broken "Download these requirements" link #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
| @@ -43,7 +43,7 @@ | |||
| </div> | |||
|
|
|||
| <div class='download-reqs'> | |||
| <a download href="QCI_Requirements.txt"> | |||
| <a href="/assets/r/QCI_Requirements.txt" target="_blank"> | |||
There was a problem hiding this comment.
@eriknelson, @jwmatthews, which browser did <a download not work? Now instead of downloading, the browser just opens the file in any tab, right?
There was a problem hiding this comment.
@isratrade the link path was not correct. We're you testing with ember dev server? That will serve static from a different location than where it needs to be for Foreman. I will check this morning and see if I can add in the download, sounds like we should keep that behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.