Allow storageclass to be empty #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sseago
commented
Sep 4, 2019
sseago
commented
- change validation for empty storageclass from Error to Warn
- Modify warning message for empty storageclass validation
jortel
reviewed
Sep 4, 2019
pkg/controller/migplan/validation.go
Outdated
| @@ -83,7 +83,7 @@ const ( | |||
| PvNoSupportedActionMessage = "PV in `persistentVolumes` [] with no `SupportedActions`." | |||
| PvInvalidStorageClassMessage = "PV in `persistentVolumes` [] has an unsupported `storageClass`." | |||
| PvInvalidAccessModeMessage = "PV in `persistentVolumes` [] has an invalid `accessMode`." | |||
| PvNoStorageClassSelectionMessage = "PV in `persistentVolumes` [] has no `Selected.StorageClass`." | |||
| PvNoStorageClassSelectionMessage = "PV in `persistentVolumes` [] has no `Selected.StorageClass` Make sure that the necessary static persistent volumes exist in the destination cluster." | |||
1) change validation for empty storageclass from Error to Warn 2) Modify warning message for empty storageclass validation
sseago
force-pushed
the
empty-storageclass
branch
from
cf670d5
to
adfdcb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.