Skip to content

Commit

Permalink
Allow storageclass to be empty
Browse files Browse the repository at this point in the history
1) change validation for empty storageclass from Error to Warn
2) Modify warning message for empty storageclass validation
  • Loading branch information
sseago committed Sep 4, 2019
1 parent 5118377 commit cf670d5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/controller/migplan/validation.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ const (
PvNoSupportedActionMessage = "PV in `persistentVolumes` [] with no `SupportedActions`."
PvInvalidStorageClassMessage = "PV in `persistentVolumes` [] has an unsupported `storageClass`."
PvInvalidAccessModeMessage = "PV in `persistentVolumes` [] has an invalid `accessMode`."
PvNoStorageClassSelectionMessage = "PV in `persistentVolumes` [] has no `Selected.StorageClass`."
PvNoStorageClassSelectionMessage = "PV in `persistentVolumes` [] has no `Selected.StorageClass` Make sure that the necessary static persistent volumes exist in the destination cluster."
PvWarnNoCephAvailableMessage = "Ceph is not available on destination. If this is desired, please install the rook operator. The following PVs will use the default storage class instead: []"
PvWarnAccessModeUnavailableMessage = "AccessMode for PVC in `persistentVolumes` [] unavailable in chosen storage class"
PvInvalidCopyMethodMessage = "PV in `persistentVolumes` [] has an invalid `copyMethod`."
Expand Down Expand Up @@ -601,7 +601,7 @@ func (r ReconcileMigPlan) validatePvSelections(plan *migapi.MigPlan) error {
plan.Status.SetCondition(migapi.Condition{
Type: PvNoStorageClassSelection,
Status: True,
Category: Error,
Category: Warn,
Message: PvNoStorageClassSelectionMessage,
Items: missingStorageClass,
})
Expand Down

0 comments on commit cf670d5

Please sign in to comment.