-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added migration identifier to all migration related logs #306
Conversation
pkg/controller/migmigration/task.go
Outdated
@@ -118,8 +119,6 @@ type Task struct { | |||
func (t *Task) Run() error { | |||
t.Log.Info( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can probably go on (1) line now as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable.
@Danil-Grigorev I have a branch with some logger fixes: #308 and added |
Looking at:
The word Migration seems kind of redundant with the migration keyword. Perhaps the logging in the Task should just be:
I still like the all CAPS because it makes those entries easier to pick out. Thoughts? |
I'll include all the changes on top of the #308. Agree with all suggestions. |
583093a
to
c2d655f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MigMigration name alone (without namespace) isn't necessarily unique, but since we expect all MigMigrations to be created in the same namespace I think this will work well enough for log filtering purposes without adding excessive clutter to the logs.
We need to be careful assuming all migmigrations are in the same namespace. If it's just for logging purposes, it's probably OK, but nothing prevents CLI users from putting migrations in whatever namespaces they want to use. I've tested this and migrations work fine, even if created in a different namespace. |
Added
migration
field to simplify the selection of migration related log entries. This could help filtering logs in the UI.