Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rustls dangerous_configuration feature #320

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

simp4t7
Copy link
Contributor

@simp4t7 simp4t7 commented Jun 29, 2023

Hi, I was having trouble connecting to docker running in minikube and figured that it's because rustls cannot handle ip addresses as hostnames without this feature. This worked as a pretty quick and easy fix. Thanks.

@fussybeaver
Copy link
Owner

Thanks for figuring this out.. According to the rustls docs:

this feature enables a dangerous() method on ClientConfig and ServerConfig that allows setting inadvisable options

I guess we don't want this enabled by default, so we'll need to feature flag this option in Bollard too.

@simp4t7
Copy link
Contributor Author

simp4t7 commented Jun 30, 2023

Cool, thanks.

I think it might not be 'dangerous' if there's no user access to the Config.

But no harm in making it a feature anyways.

@fussybeaver
Copy link
Owner

Hmm.. I think you're right, let's just merge this.

@fussybeaver fussybeaver merged commit ddab673 into fussybeaver:master Jun 30, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants