feat: Add connect_with_defaults #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `connect_with_defaults` function that intelligently selects the best connection method to use based on the `DOCKER_HOST` and `DOCKER_TLS_VERIFY` environment variables. This mimics the logic of the Docker CLI.
|
I have not tested this yet. Hope to do that sometime this coming week. |
|
Thanks for the contribution, I'm away from my computer for a week, but looking through the PR it looks good. Maybe we can figure out how to test each branch somehow. |
|
I think the best way to test the branches is to use the docker DinD image to launch different docker daemons and attempt to connect. I'll try to set it up this weekend if I can find some time. |
|
Adding tests in #373 |
|
Thank you and sorry for not getting to the tests myself 🙏🏼 |
|
Hate to be this person, but will there be a new release in the near future? |
|
Yeah, we're very close. My only reservation is that we now need to peg to a GitHub revision of the hyperlocal dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
connect_with_defaultsfunction that intelligently selects the best connection method to use based on theDOCKER_HOSTandDOCKER_TLS_VERIFYenvironment variables. This mimics the logic of the Docker CLI.Fixes #310