Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update products.json #31

Merged
merged 3 commits into from
Oct 31, 2020
Merged

Update products.json #31

merged 3 commits into from
Oct 31, 2020

Conversation

r1ch
Copy link
Contributor

@r1ch r1ch commented Oct 30, 2020

I copied this from https://github.com/LIFX/products/blob/master/products.json

However, I've done spaces -> tabs so the PR is easier to read and culled parameters that weren't present in the previous file (though I'm not aware of backwards compatibility issues in adding them).

This DOES change the name of some products, but that is to line them up with Lifx's names.

Mine wasn't picking up a new bulb without this - (and it does now)

@r1ch
Copy link
Contributor Author

r1ch commented Oct 30, 2020

P.S. Thanks @futomi for a great library

@futomi futomi merged commit 63f5e3e into futomi:master Oct 31, 2020
@futomi
Copy link
Owner

futomi commented Oct 31, 2020

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants