Fixed false positives when ignoreBEMModifier and captureClassesFromDo…

…c were used together in `no-unused-selector` and `require-selector-used-inside`. (#21)
future-architect · Jan 14, 2020 · dd6852e · dd6852e
1 parent a435eda
commit dd6852e
Show file tree

Hide file tree

Showing 6 changed files with 61 additions and 6 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -2,18 +2,21 @@
   "eslint.validate": [
     "javascript",
     "javascriptreact",
-    { "language": "vue", "autoFix": true },
-    { "autoFix": true, "language": "typescript" },
+    "vue",
+    "typescript"
   ],
   "typescript.validate.enable": true,
   "javascript.validate.enable": false,
-  "eslint.autoFixOnSave": true,
   "eslint.workingDirectories": [
     {"directory": "./", "changeProcessCWD": true },
     {"directory": "./docs/.vuepress", "changeProcessCWD": true }
   ],
   "vetur.validation.script": false,
   "vetur.validation.style": false,
   "css.validate": false,
-  "typescript.tsdk": "node_modules/typescript/lib"
+  "typescript.tsdk": "node_modules/typescript/lib",
+  "editor.codeActionsOnSave": {
+    "source.fixAll.eslint": true
+  },
+  "editor.codeActionsOnSaveTimeout": 7500
 }
diff --git a/lib/styles/selectors/query/index.ts b/lib/styles/selectors/query/index.ts
@@ -506,6 +506,12 @@ function* genElementsByClassName(
             // If the class name is documented, it is considered to match all elements.
             yield* elements
             return
+        } else if (removeModifierClassName) {
+            if (removeModifierClassName.matchString(modClassName)) {
+                // If the class name is documented, it is considered to match all elements.
+                yield* elements
+                return
+            }
         }
     }
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-vue-scoped-css",
-  "version": "0.3.1",
+  "version": "0.3.2",
   "description": "ESLint plugin for Scoped CSS in Vue.js",
   "main": "dist/index.js",
   "scripts": {

diff --git a/tests/lib/rules/no-unused-selector.ts b/tests/lib/rules/no-unused-selector.ts
@@ -301,6 +301,29 @@ tester.run("no-unused-selector", rule, {
                 },
             ],
         },
+        {
+            code: `
+            <template>
+                <div></div>
+            </template>
+            <style scoped>
+            /* .element        - doc. */
+            .element {
+                color: green;
+            }
+            .element--mod {
+                color: red;
+            }
+            </style>`,
+            options: [
+                {
+                    ignoreBEMModifier: true,
+                    captureClassesFromDoc: [
+                        "/(\\.[a-z-]+)(?::[a-z-]+)?\\s+-\\s*[^\\r\\n]+/i",
+                    ],
+                },
+            ],
+        },
         // ignore nodes
         `
         <template>

diff --git a/tests/lib/rules/require-selector-used-inside.ts b/tests/lib/rules/require-selector-used-inside.ts
@@ -262,6 +262,29 @@ tester.run("require-selector-used-inside", rule, {
                 },
             ],
         },
+        {
+            code: `
+            <template>
+                <div></div>
+            </template>
+            <style scoped>
+            /* .element        - doc. */
+            .element {
+                color: green;
+            }
+            .element--mod {
+                color: red;
+            }
+            </style>`,
+            options: [
+                {
+                    ignoreBEMModifier: true,
+                    captureClassesFromDoc: [
+                        "/(\\.[a-z-]+)(?::[a-z-]+)?\\s+-\\s*[^\\r\\n]+/i",
+                    ],
+                },
+            ],
+        },
         // ignore nodes
         `
         <template>