Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): default.user not set in cofnig.toml, add --assume-yes to dnf mod list #1126

Merged
merged 1 commit into from Jan 13, 2021

Conversation

shigechika
Copy link
Contributor

@shigechika shigechika commented Jan 13, 2021

What did you implement:

  • Bypass with -assumeyes when dnf module list stoped at GPG key import prompt appeared.

  • Fix to use ssh default user when server.user is empty.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

@kotakanbe kotakanbe merged commit fca102e into future-architect:master Jan 13, 2021
@kotakanbe
Copy link
Member

LGTM

@kotakanbe
Copy link
Member

kotakanbe commented Jan 13, 2021

It works correctly with the below config.

[default]
    port = "22"
    scanMode = ["fast"]
    user = "ec2-user"

[servers]
[servers.rhel8]
host = "3.112.204.xxx"
keyPath = "/home/ubuntu/.ssh/stg.pem"
scanMode = ["fast"]

[servers.localhost]
host = "localhost"
port = "local"
scanMode = ["fast"]

@kotakanbe kotakanbe changed the title fix dnf prompt and ssh user fix(config): default.user not set in cofnig.toml, add --assume-yes to dnf mod list Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants